gh-139801: fix BaseProxy pickling with custom authkey#144311
gh-139801: fix BaseProxy pickling with custom authkey#144311deadlovelll wants to merge 1 commit intopython:mainfrom
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
I'll be glad to see the feedback! Thanks =) |
|
Well.. one feedback I can give without looking at the PR is that tests should not fail, or you should have an idea why it fails, before requesting a review. We can't make the work of fixing the tests ourselves (otherwise we would have worked on the PR directly). So I suggest that you investigate why the tests fail and at least make sure that some tests succeed (at least on Ubuntu). In the meantime, I'm marking this PR as not ready. EDIT: I think you need to tackle a less complex issue. This issue is actually related to security and we prefer core developers making changes to security-related issues (the TypeError in the tests hint that we should not pickle some data). |
Thank you! I'll try not to make same mistakes again |
Always save
authkeyinBaseProxy.__reduce__()so proxy created with a custom authkey could be picklable.Fixes gh-139801.